Checking the Atmosphere Theme

Digital Raindrops have had their first theme accepted into the WordPress themes directory, we learned quite a bit while preparing the theme for the directory and discovered that some of the calls we have in our code have been superseded, so we thought we would create a post with some details about these.

Even if you are not creating a theme for the WordPress directory, we would recommend theme developers using the test data and tools that are used for submitting to WordPress, you cannot submit Child Themes or Artisteer themes to the WordPress theme directory, we just re-engineered the twenty ten theme.

Atmosphere 2010

screenshot This theme was created for fun in response to a topic in the WordPress support forum, you can view the theme at the demo website theme Atmosphere 2010, this theme is a simple but pleasant two column narrow theme, the new theme based on the atmosphere theme published back in 2007, we could not find the original authors contact details, so we created a new theme based on the look and feel of the original.

The theme can be downloaded from the downloads page or from WordPress, we were amazed at the number of downloads, over 400 in less than twenty four hours, compared with about 40 a month from this website, we also have a page which will show you how to manage the theme.

Test Data

WordPress have made available test data which we imported from Admin > Tools > Import, to get a copy of this file to use you will need to register over at WordPress.org, then login on the themes page and download the themes test data

Theme Check

We used the Theme Check plugin which checked all your files for deprecated code and recommended replacements, this picked up where we had used is_term() and get_settings() and recommended replacements, lets just run the plugin and have a look at the results from a new clean Artisteer Theme, this does not mean the theme is broken and are just advisory.

Deprecated:

  • wp_specialchars use esc_html()
  • attribute_escape use esc_attr()
  • register_sidebar_widget use wp_register_sidebar_widget()

Required:

  • license.txt is missing you must include a licence.txt or Licence URI: in style.css header..
  • .gallery-caption is missing.

Recommended:

  • The CSS is missing the .sticky class.
  • The CSS is missing the .bypostauthor class.
  • No reference to add_custom_image_header() was found.
  • No reference to add_custom_background() was found.
  • No reference to add_editor_style() was found.
  • bloginfo(‘template_directory’) use get_template_directory_uri().
  • get_option(‘home’) use home_url() instead.
  • bloginfo(‘wpurl’) use echo site_url() instead.

Info:

  • The theme appears to use include or require where possible get_template_part() should be used instead.
  • Non-printable characters were found, You may want to check this file for errors. (possible pasted from word?)

Submitting the Theme

We packaged and submitted the theme to the WordPress directory and got a rejection:

Theme Review:
=>Themes should be reviewed using “define(‘WP_DEBUG’, true);” in wp-
config.php

=>Themes should be reviewed using the test data from the Theme Checklists
(TC)

We just set the debug to true in the wp-config.php, and downloaded the test data file. 

 
WP_DEBUG et al.:
— Debug: Undefined index: action on line 274 of /wp-
content/themes/atmosphere-2010/admin-options.php (Theme Options)
— Debug: Undefined variable: style on line 78 of /wp-
content/themes/atmosphere-2010/header.php (single view)

This was where we had used not use isset() for the theme options, and used a conditional variable which was not set.

General Observations:
– Info: Non-printable characters were found in the /wp-
content/themes/atmosphere-2010/functions.php  file. You may want to check
this file for errors.
-> “Top of Page” appears to the far right but does not appear to do
anything?!
=> This is a re-work of the Twenty Ten theme made most obvious by using
the ‘twentyten_’ namespace. This is not allowed. The namespace for a theme
must be unique to the theme for inclusion in the Theme repository, suggest
using ‘atmosphere_’.
=> Note, this also applies to the theme’s textdomain if
internationalization is being implemented.

The non printable character was in a comment from the twenty ten theme, we removed most of the comments to cut down the file sizes, “Top of Page” had a broken link.

Namespace we searched and replaced all code instances of twentyten for atmosphere in all files, renamed and edited the language file (textdomain).

Conclusion

We went from version 1.0 to 1.5 within this process, however we have learnt a lot from doing this, and the theme is getting the downloads rather than sitting on our downloads page, the tools will become part of the process we will use going forward for our themes.

Notices

We do require your feedback to improve our themes and tutorials, please leave your comments good or bad.

Code disclaimer information

If this document contains programming examples, www.DigitalRaindrops.net grants you a nonexclusive copyright license to use all programming code from which you can generate similar functions tailored to your own specific needs.

All sample code is provided by http://DigitalRaindrops.net for learning illustrative purposes only.

These examples have not been thoroughly tested under all conditions. www.DigitalRaindrops.net, therefore, cannot guarantee or imply reliability, serviceability, or function of these examples.

All programs contained herein are provided to you “AS IS” without any warranties of any kind. The implied warranties of non-infringement, merchantability and fitness for a particular purpose are expressly disclaimed.

Membership

Registration and Membership is no longer required for downloading files or interacting with Digital Raindrops, posting a comment or topic in the forum does use Captcha to reduce spammers.

This website is a tool to support and promote WordPress and Artisteer theme development, please support, share and give credit for any benefits you gain from the tutorials on this website.

10 thoughts on “Checking the Atmosphere Theme

  1. Pingback: House of Brinson - House Of Brinson - Wordpress Video Tutorials

  2. Pingback: Tweets that mention Checking the Atmosphere Theme | Digital Raindrops -- Topsy.com

    • Hi Garball44,
      I uploaded a fix yesterday for this and several other small issues, see the theme page.

      The updated theme is available here on the downloads page and once reviewed by WordPress it should be an auto update.

      For security reasons I have changed the theme options page, when you upgrade you will lose the settings and have to re-enter these.

      Thanks for taking the time to leave feedback, it is most welcome.

      David

  3. I second what Garball44 says, and in addition to that found another error:

    When one adds social networking icons, the icons do not show up on the website because the folder that the icons are in does not correctly match the reference. i.e. the folder is expected to be “24X24” and the actual folder is “24×24” with a lower-case “X”. When I change this it intrrupts the wordpress UI. The temporary fix for me was to duplicate the folders with both names but it should be fixed at the source as most people will want to use this social networking option.

    • Hi Jon,
      Thanks for this it was driving me mad, and it is a simple typo, I uploaded a fix yesterday for this and several other small issues, see the theme page, I moved the icons into the icons folder (up a level) and removed the other folders.

      The updated theme is available here on the downloads page and once reviewed by WordPress it should be an auto update.

      For security reasons I have changed the theme options page, when you upgrade you will lose the settings and have to reenter these.

      Thanks for taking the time to leave feedback, it is most welcome.

      David

  4. I’m trying to adjust the header so the image header height is bigger. It won’t let me change the header.php to adjust the settings I need though. Any recommendation or is there something I might be able to do?

  5. Hi..love this theme. However I am having issue with the scale value when i embed video. for some reason the template is not listening to the “aspect” and “tofit” values. no change occurs at all. This problem does not exist on my other wordpress site with a different template. I have looked in the style sheet but cant find why this problem occurs. thank you for any assistance.

  6. Hi..love this theme. I have looked in the your other theme also. It is one of best among them.
    thank you for adding this article and helping all.

Leave a Reply

Connections

Connect with Us
Follow Digital Raindrops on Twitter Join Digital Raindrops on Facebook
Share

Related Posts

Posted in Themes

tabbed

We were searching for code to create a tabbed admin page for our WordPress to facebook Plugin, and we found a very nice website with the code we needed, the website is recommended as one to visit. It took a … Continue reading

Read More

Posted in Tips

colorizer-1_thumb.png

We thought we would use the WordPress Twenty Eleven theme and the the Farbtastic color picker to colorize our theme from the website front page instead of the admin area. We have been looking at the $_SESSION variable, so we thought … Continue reading

Read More